summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorSergey Popovich <popovich_sergei@mail.ru>2014-05-08 16:22:35 +0300
committerJiri Slaby <jslaby@suse.cz>2014-06-04 16:57:04 +0200
commit2b713fc5d2da1dc1ec7ce894f2674d65cb47727f (patch)
tree5bca2571e04e5d97fc3fadb7ba55540b9bfdee08 /net
parent97da00224a0f38adec8a020ad5d1135881510999 (diff)
downloadlwn-2b713fc5d2da1dc1ec7ce894f2674d65cb47727f.tar.gz
lwn-2b713fc5d2da1dc1ec7ce894f2674d65cb47727f.zip
netfilter: Fix potential use after free in ip6_route_me_harder()
commit a8951d5814e1373807a94f79f7ccec7041325470 upstream. Dst is released one line before we access it again with dst->error. Fixes: 58e35d147128 netfilter: ipv6: propagate routing errors from ip6_route_me_harder() Signed-off-by: Sergey Popovich <popovich_sergei@mail.ru> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'net')
-rw-r--r--net/ipv6/netfilter.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index 95f3f1da0d7f..d38e6a8d8b9f 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -30,13 +30,15 @@ int ip6_route_me_harder(struct sk_buff *skb)
.daddr = iph->daddr,
.saddr = iph->saddr,
};
+ int err;
dst = ip6_route_output(net, skb->sk, &fl6);
- if (dst->error) {
+ err = dst->error;
+ if (err) {
IP6_INC_STATS(net, ip6_dst_idev(dst), IPSTATS_MIB_OUTNOROUTES);
LIMIT_NETDEBUG(KERN_DEBUG "ip6_route_me_harder: No more route.\n");
dst_release(dst);
- return dst->error;
+ return err;
}
/* Drop old route. */