diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-02-10 11:57:16 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-02-13 11:21:14 -0800 |
| commit | d3337de52af7fb0ebe605b02b740be4ee7dee9eb (patch) | |
| tree | 1788ad68e863e2aa8c6cbf50ceab25d39827bc5b /net | |
| parent | 7ec79270d7de0c8ca602c47cb25a9652ec28f37f (diff) | |
| download | lwn-d3337de52af7fb0ebe605b02b740be4ee7dee9eb.tar.gz lwn-d3337de52af7fb0ebe605b02b740be4ee7dee9eb.zip | |
Don't potentially dereference NULL in net/dcb/dcbnl.c:dcbnl_getapp()
nla_nest_start() may return NULL. If it does then we'll blow up in
nla_nest_end() when we dereference the pointer.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/dcb/dcbnl.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index 712ca026040a..d5074a567289 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -626,6 +626,9 @@ static int dcbnl_getapp(struct net_device *netdev, struct nlattr **tb, dcb->cmd = DCB_CMD_GAPP; app_nest = nla_nest_start(dcbnl_skb, DCB_ATTR_APP); + if (!app_nest) + goto out_cancel; + ret = nla_put_u8(dcbnl_skb, DCB_APP_ATTR_IDTYPE, idtype); if (ret) goto out_cancel; |