diff options
author | Andy Whitcroft <apw@canonical.com> | 2009-10-26 16:50:16 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-10-29 07:39:31 -0700 |
commit | 2b474a1a566064b40bc7d9a45021ffbc4c894fa3 (patch) | |
tree | 9f65e5456a95272db6ec887eff472114bfcc5d31 /net | |
parent | 99423c2065b62fee41cdbd8da7e63bf1f8f9e9b0 (diff) | |
download | lwn-2b474a1a566064b40bc7d9a45021ffbc4c894fa3.tar.gz lwn-2b474a1a566064b40bc7d9a45021ffbc4c894fa3.zip |
checkpatch: fix false EXPORT_SYMBOL warning
Ingo reported that the following lines triggered a false warning,
static struct lock_class_key rcu_lock_key;
struct lockdep_map rcu_lock_map =
STATIC_LOCKDEP_MAP_INIT("rcu_read_lock", &rcu_lock_key);
EXPORT_SYMBOL_GPL(rcu_lock_map);
from kernel/rcutree.c , and the false warning looked like this,
WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable
+EXPORT_SYMBOL_GPL(rcu_lock_map);
We actually should be checking the statement before the EXPORT_* for a
mention of the exported object, and complain where it is not there.
[akpm@linux-foundation.org: coding-style fixes]
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reported-by: Daniel Walker <dwalker@fifo99.com>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions