diff options
| author | Oliver Hartkopp <socketcan@hartkopp.net> | 2010-11-10 12:10:30 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:27:10 -0800 |
| commit | e2de51a1c73d762ee1b5246053b087e295f4a7e9 (patch) | |
| tree | c709345174e2828eea64586a9b61fe9fb544c520 /net | |
| parent | f0c12133cff646d3ad1cb65f23c512169c85e65f (diff) | |
| download | lwn-e2de51a1c73d762ee1b5246053b087e295f4a7e9.tar.gz lwn-e2de51a1c73d762ee1b5246053b087e295f4a7e9.zip | |
can-bcm: fix minor heap overflow
commit 0597d1b99fcfc2c0eada09a698f85ed413d4ba84 upstream.
On 64-bit platforms the ASCII representation of a pointer may be up to 17
bytes long. This patch increases the length of the buffer accordingly.
http://marc.info/?l=linux-netdev&m=128872251418192&w=2
Reported-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
CC: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/can/bcm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/can/bcm.c b/net/can/bcm.c index ff8c69000bf3..4a192f7d93f8 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -124,7 +124,7 @@ struct bcm_sock { struct list_head tx_ops; unsigned long dropped_usr_msgs; struct proc_dir_entry *bcm_proc_read; - char procname [9]; /* pointer printed in ASCII with \0 */ + char procname [20]; /* pointer printed in ASCII with \0 */ }; static inline struct bcm_sock *bcm_sk(const struct sock *sk) |