diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2009-08-23 16:59:04 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-04-01 15:52:24 -0700 |
| commit | 3807f5c31534736f3c23630b11bd4a259eaa46fd (patch) | |
| tree | 259c1c773bbc5efaa24e4c6e0d26ef04571bf6d6 /net | |
| parent | 0a32cd3d6adbe5cbfdfb411e1b1fccceec75e36a (diff) | |
| download | lwn-3807f5c31534736f3c23630b11bd4a259eaa46fd.tar.gz lwn-3807f5c31534736f3c23630b11bd4a259eaa46fd.zip | |
drm/r128: Add test for initialisation to all ioctls that require it
commit 7dc482dfeeeefcfd000d4271c4626937406756d7 upstream.
Almost all r128's private ioctls require that the CCE state has
already been initialised. However, most do not test that this has
been done, and will proceed to dereference a null pointer. This may
result in a security vulnerability, since some ioctls are
unprivileged.
This adds a macro for the common initialisation test and changes all
ioctl implementations that require prior initialisation to use that
macro.
Also, r128_do_init_cce() does not test that the CCE state has not
been initialised already. Repeated initialisation may lead to a crash
or resource leak. This adds that test.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions