diff options
| author | James Chapman <jchapman@katalix.com> | 2008-05-19 14:10:01 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-06-16 13:19:56 -0700 |
| commit | 85339198d7abe9edf5204381e0d756c773a739e8 (patch) | |
| tree | 06e179d6716b34cf267b8f7d2f220f7092565df1 /net | |
| parent | f118d52421c0f803b89fb42dc6448cacbafbd8ee (diff) | |
| download | lwn-85339198d7abe9edf5204381e0d756c773a739e8.tar.gz lwn-85339198d7abe9edf5204381e0d756c773a739e8.zip | |
l2tp: avoid skb truesize bug if headroom is increased
[ upstream commit: 090c48d3dd5ea90b37350334aaed9a93b0c1e0a1 ]
A user reported seeing occasional bugs such as the following when
using the L2TP driver.
SKB BUG: Invalid truesize (272) len=72, sizeof(sk_buff)=208
When L2TP adds its header in the transmit path, it might need to
increase the headroom of the skb. In some cases, the increased
headroom trips a kernel bug when the skb is freed because the skb has
grown beyond its truesize value. The fix is to increase the truesize
by the amount of headroom added, after orphaning the skb.
While here, fix a misleading comment.
Thanks to Iouri Kharon <bc-info@styx.cabel.net> for the initial
report and testing the fix.
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions