diff options
| author | Hoang Le <hoang.h.le@dektech.com.au> | 2021-03-11 10:33:22 +0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-11 18:06:54 -0800 |
| commit | 1980d37565061ab44bdc2f9e4da477d3b9752e81 (patch) | |
| tree | bd41889e1db535df3ccf4f1d2332137175483b8e /net | |
| parent | 1520929e26d54bc3c9e024ee91eee5a19c56b95b (diff) | |
| download | lwn-1980d37565061ab44bdc2f9e4da477d3b9752e81.tar.gz lwn-1980d37565061ab44bdc2f9e4da477d3b9752e81.zip | |
tipc: convert dest node's address to network order
(struct tipc_link_info)->dest is in network order (__be32), so we must
convert the value to network order before assigning. The problem detected
by sparse:
net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)
net/tipc/netlink_compat.c:699:24: expected restricted __be32 [usertype] dest
net/tipc/netlink_compat.c:699:24: got int
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/tipc/netlink_compat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 5a1ce64039f7..0749df80454d 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -696,7 +696,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg, if (err) return err; - link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]); + link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST])); link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP])); nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME], TIPC_MAX_LINK_NAME); |