diff options
| author | Sabrina Dubroca <sd@queasysnail.net> | 2015-11-04 14:47:53 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-11-04 23:49:48 -0500 |
| commit | 2a189f9e57650e9f310ddf4aad75d66c1233a064 (patch) | |
| tree | 17c6ae06a11ef65498f8bddf246516fe39477288 /net | |
| parent | 87aec47d173ca730d014b6b0246ca6be18b0ce94 (diff) | |
| download | lwn-2a189f9e57650e9f310ddf4aad75d66c1233a064.tar.gz lwn-2a189f9e57650e9f310ddf4aad75d66c1233a064.zip | |
ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev
In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up
the dev_snmp6 entry that we have already registered for this device.
Call snmp6_unregister_dev in this case.
Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/addrconf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d72fa90d6feb..d84742f003a9 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -418,6 +418,7 @@ static struct inet6_dev *ipv6_add_dev(struct net_device *dev) if (err) { ipv6_mc_destroy_dev(ndev); del_timer(&ndev->regen_timer); + snmp6_unregister_dev(ndev); goto err_release; } /* protected by rtnl_lock */ |