diff options
| author | Steffen Klassert <steffen.klassert@secunet.com> | 2011-09-20 23:38:58 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-09-21 15:20:57 -0400 |
| commit | bcf66bf54aabffc150acd1c99e0f4bc51935eada (patch) | |
| tree | 7373ca2db919a39ea8f2e11416c881121ade0930 /net/xfrm | |
| parent | 561dac2d410ffac0b57a23b85ae0a623c1a076ca (diff) | |
| download | lwn-bcf66bf54aabffc150acd1c99e0f4bc51935eada.tar.gz lwn-bcf66bf54aabffc150acd1c99e0f4bc51935eada.zip | |
xfrm: Perform a replay check after return from async codepaths
When asyncronous crypto algorithms are used, there might be many
packets that passed the xfrm replay check, but the replay advance
function is not called yet for these packets. So the replay check
function would accept a replay of all of these packets. Also the
system might crash if there are more packets in async processing
than the size of the anti replay window, because the replay advance
function would try to update the replay window beyond the bounds.
This pach adds a second replay check after resuming from the async
processing to fix these issues.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/xfrm')
| -rw-r--r-- | net/xfrm/xfrm_input.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index a026b0ef2443..54a0dc2e2f8d 100644 --- a/net/xfrm/xfrm_input.c +++ b/net/xfrm/xfrm_input.c @@ -212,6 +212,11 @@ resume: /* only the first xfrm gets the encap type */ encap_type = 0; + if (async && x->repl->check(x, skb, seq)) { + XFRM_INC_STATS(net, LINUX_MIB_XFRMINSTATESEQERROR); + goto drop_unlock; + } + x->repl->advance(x, seq); x->curlft.bytes += skb->len; |