diff options
| author | Apollon Oikonomopoulos <apollon@noc.grnet.gr> | 2010-12-07 09:43:30 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-12-08 12:13:44 -0800 |
| commit | 171995e5d82dcc92bea37a7d2a2ecc21068a0f19 (patch) | |
| tree | d0c6d6650a244f4860edff9f9d20ae9ea98dd85f /net/x25/x25_link.c | |
| parent | 408cc293c29ada769ae772420a39961320da1854 (diff) | |
| download | lwn-171995e5d82dcc92bea37a7d2a2ecc21068a0f19.tar.gz lwn-171995e5d82dcc92bea37a7d2a2ecc21068a0f19.zip | |
x25: decrement netdev reference counts on unload
x25 does not decrement the network device reference counts on module unload.
Thus unregistering any pre-existing interface after unloading the x25 module
hangs and results in
unregister_netdevice: waiting for tap0 to become free. Usage count = 1
This patch decrements the reference counts of all interfaces in x25_link_free,
the way it is already done in x25_link_device_down for NETDEV_DOWN events.
Signed-off-by: Apollon Oikonomopoulos <apollon@noc.grnet.gr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25/x25_link.c')
| -rw-r--r-- | net/x25/x25_link.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c index 73e7b954ad28..b25c6463c3e9 100644 --- a/net/x25/x25_link.c +++ b/net/x25/x25_link.c @@ -394,6 +394,7 @@ void __exit x25_link_free(void) list_for_each_safe(entry, tmp, &x25_neigh_list) { nb = list_entry(entry, struct x25_neigh, node); __x25_remove_neigh(nb); + dev_put(nb->dev); } write_unlock_bh(&x25_neigh_list_lock); } |