diff options
| author | Tom Tucker <tom@opengridcomputing.com> | 2007-12-30 21:07:38 -0600 |
|---|---|---|
| committer | J. Bruce Fields <bfields@citi.umich.edu> | 2008-02-01 16:42:09 -0500 |
| commit | 44a6995b32eb9b021ee71b279edb84728c9f5160 (patch) | |
| tree | fbe6492dc072aaf80cda94353e2bfce8738802e9 /net/sunrpc | |
| parent | 38a417cc993f4535548e47207f9894e7c27e05e4 (diff) | |
| download | lwn-44a6995b32eb9b021ee71b279edb84728c9f5160.tar.gz lwn-44a6995b32eb9b021ee71b279edb84728c9f5160.zip | |
svc: Remove unnecessary call to svc_sock_enqueue
The svc_tcp_accept function calls svc_sock_enqueue after setting the
SK_CONN bit. This doesn't actually do anything because the SK_BUSY bit
is still set. The call is unnecessary anyway because the generic code in
svc_recv calls svc_sock_received after calling the accept function.
Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
Acked-by: Neil Brown <neilb@suse.de>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Greg Banks <gnb@sgi.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/svcsock.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 41d1f815fbbd..962dbf43a728 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -1064,7 +1064,6 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt) } set_bit(SK_CONN, &svsk->sk_flags); - svc_sock_enqueue(svsk); err = kernel_getpeername(newsock, sin, &slen); if (err < 0) { |