diff options
| author | yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn> | 2017-01-07 17:18:31 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-09 12:05:29 -0500 |
| commit | 1e9116327e1dbbf33fcb539c977ff39e1c680e6c (patch) | |
| tree | 95afb60289c0c10cc14020da2a296ad4127abe1c /net/socket.c | |
| parent | 4289e60cb056ccae4311197d8a4a798aca0f8e55 (diff) | |
| download | lwn-1e9116327e1dbbf33fcb539c977ff39e1c680e6c.tar.gz lwn-1e9116327e1dbbf33fcb539c977ff39e1c680e6c.zip | |
net: change init_inodecache() return void
sock_init() call it but not check it's return value,
so change it to void return and add an internal BUG_ON() check.
Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/socket.c')
| -rw-r--r-- | net/socket.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/socket.c b/net/socket.c index c65bb927b104..3ef02e97ecf3 100644 --- a/net/socket.c +++ b/net/socket.c @@ -287,7 +287,7 @@ static void init_once(void *foo) inode_init_once(&ei->vfs_inode); } -static int init_inodecache(void) +static void init_inodecache(void) { sock_inode_cachep = kmem_cache_create("sock_inode_cache", sizeof(struct socket_alloc), @@ -296,9 +296,7 @@ static int init_inodecache(void) SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT), init_once); - if (sock_inode_cachep == NULL) - return -ENOMEM; - return 0; + BUG_ON(sock_inode_cachep == NULL); } static const struct super_operations sockfs_ops = { |