diff options
| author | Karsten Graul <kgraul@linux.ibm.com> | 2019-01-30 18:51:08 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-01 14:45:45 -0800 |
| commit | 46ad02229d6b4ee276eb295ca08f039993f323c8 (patch) | |
| tree | ba921dc696d6047a9e30805bdb39d2c5dbca42d9 /net/smc | |
| parent | e5f3aa04dbfd92154f21edfeb7a1676a45918928 (diff) | |
| download | lwn-46ad02229d6b4ee276eb295ca08f039993f323c8.tar.gz lwn-46ad02229d6b4ee276eb295ca08f039993f323c8.zip | |
net/smc: fix use of variable in cleared area
Do not use pend->idx as index for the arrays because its value is
located in the cleared area. Use the existing local variable instead.
Without this fix the wrong area might be cleared.
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
| -rw-r--r-- | net/smc/smc_wr.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/smc/smc_wr.c b/net/smc/smc_wr.c index c2694750a6a8..1dc88c32d6bb 100644 --- a/net/smc/smc_wr.c +++ b/net/smc/smc_wr.c @@ -218,10 +218,10 @@ int smc_wr_tx_put_slot(struct smc_link *link, u32 idx = pend->idx; /* clear the full struct smc_wr_tx_pend including .priv */ - memset(&link->wr_tx_pends[pend->idx], 0, - sizeof(link->wr_tx_pends[pend->idx])); - memset(&link->wr_tx_bufs[pend->idx], 0, - sizeof(link->wr_tx_bufs[pend->idx])); + memset(&link->wr_tx_pends[idx], 0, + sizeof(link->wr_tx_pends[idx])); + memset(&link->wr_tx_bufs[idx], 0, + sizeof(link->wr_tx_bufs[idx])); test_and_clear_bit(idx, link->wr_tx_mask); return 1; } |