diff options
| author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2018-06-20 12:47:52 -0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-06-21 12:49:33 +0900 |
| commit | fedb1bd3d274b33c432cb83c80c6b3cf54d509c8 (patch) | |
| tree | 4a9114717845d1a3e835cdc386b80ceee4c13e36 /net/sctp | |
| parent | 9262478220eac908ae6e168c3df2c453c87e2da3 (diff) | |
| download | lwn-fedb1bd3d274b33c432cb83c80c6b3cf54d509c8.tar.gz lwn-fedb1bd3d274b33c432cb83c80c6b3cf54d509c8.zip | |
sctp: fix erroneous inc of snmp SctpFragUsrMsgs
Currently it is incrementing SctpFragUsrMsgs when the user message size
is of the exactly same size as the maximum fragment size, which is wrong.
The fix is to increment it only when user message is bigger than the
maximum fragment size.
Fixes: bfd2e4b8734d ("sctp: refactor sctp_datamsg_from_user")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/chunk.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sctp/chunk.c b/net/sctp/chunk.c index 79daa98208c3..bfb9f812e2ef 100644 --- a/net/sctp/chunk.c +++ b/net/sctp/chunk.c @@ -237,7 +237,9 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc, /* Account for a different sized first fragment */ if (msg_len >= first_len) { msg->can_delay = 0; - SCTP_INC_STATS(sock_net(asoc->base.sk), SCTP_MIB_FRAGUSRMSGS); + if (msg_len > first_len) + SCTP_INC_STATS(sock_net(asoc->base.sk), + SCTP_MIB_FRAGUSRMSGS); } else { /* Which may be the only one... */ first_len = msg_len; |