diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-01-20 13:01:57 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-20 11:26:01 -0500 |
| commit | 0e73fc9a56f22f2eec4d2b2910c649f7af67b74d (patch) | |
| tree | 23560da128b25833d3579b9dd8bafd4628b49502 /net/sctp | |
| parent | e363116b90906f326c9cde5473b4b9a99ba476df (diff) | |
| download | lwn-0e73fc9a56f22f2eec4d2b2910c649f7af67b74d.tar.gz lwn-0e73fc9a56f22f2eec4d2b2910c649f7af67b74d.zip | |
net: sctp: fix array overrun read on sctp_timer_tbl
The comparison on the timeout can lead to an array overrun
read on sctp_timer_tbl because of an off-by-one error. Fix
this by using < instead of <= and also compare to the array
size rather than SCTP_EVENT_TIMEOUT_MAX.
Fixes CoverityScan CID#1397639 ("Out-of-bounds read")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/debug.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/debug.c b/net/sctp/debug.c index 95d7b15dad21..e371a0d90068 100644 --- a/net/sctp/debug.c +++ b/net/sctp/debug.c @@ -166,7 +166,7 @@ static const char *const sctp_timer_tbl[] = { /* Lookup timer debug name. */ const char *sctp_tname(const sctp_subtype_t id) { - if (id.timeout <= SCTP_EVENT_TIMEOUT_MAX) + if (id.timeout < ARRAY_SIZE(sctp_timer_tbl)) return sctp_timer_tbl[id.timeout]; return "unknown_timer"; } |