diff options
| author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2009-02-13 08:33:43 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-16 00:03:10 -0800 |
| commit | faee47cdbfe8d74a1573c2f81ea6dbb08d735be6 (patch) | |
| tree | 6a95e8f91087cd3d584fc89f9bc06355d371d82a /net/sctp/transport.c | |
| parent | 4458f04c02a46c679a90ef71f866a415c192deb4 (diff) | |
| download | lwn-faee47cdbfe8d74a1573c2f81ea6dbb08d735be6.tar.gz lwn-faee47cdbfe8d74a1573c2f81ea6dbb08d735be6.zip | |
sctp: Fix the RTO-doubling on idle-link heartbeats
SCTP incorrectly doubles rto ever time a Hearbeat chunk
is generated. However RFC 4960 states:
On an idle destination address that is allowed to heartbeat, it is
recommended that a HEARTBEAT chunk is sent once per RTO of that
destination address plus the protocol parameter 'HB.interval', with
jittering of +/- 50% of the RTO value, and exponential backoff of the
RTO if the previous HEARTBEAT is unanswered.
Essentially, of if the heartbean is unacknowledged, do we double the RTO.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/transport.c')
| -rw-r--r-- | net/sctp/transport.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sctp/transport.c b/net/sctp/transport.c index e745c118f239..5c29b14ee9af 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -79,6 +79,7 @@ static struct sctp_transport *sctp_transport_init(struct sctp_transport *peer, peer->rttvar = 0; peer->srtt = 0; peer->rto_pending = 0; + peer->hb_sent = 0; peer->fast_recovery = 0; peer->last_time_heard = jiffies; @@ -608,6 +609,7 @@ void sctp_transport_reset(struct sctp_transport *t) t->flight_size = 0; t->error_count = 0; t->rto_pending = 0; + t->hb_sent = 0; t->fast_recovery = 0; /* Initialize the state information for SFR-CACC */ |