diff options
| author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2015-09-02 16:20:21 -0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-09-03 15:43:05 -0700 |
| commit | d82f0f1fc8a4f214a50c9dfc64e3896f9894afb7 (patch) | |
| tree | f5d68b981119d7540589a233e8cdbd8573ae1983 /net/sctp/protocol.c | |
| parent | 4548a697e4969d695047cebd6d9af5e2f6cc728e (diff) | |
| download | lwn-d82f0f1fc8a4f214a50c9dfc64e3896f9894afb7.tar.gz lwn-d82f0f1fc8a4f214a50c9dfc64e3896f9894afb7.zip | |
sctp: fix dst leak
Commit 0ca50d12fe46 failed to release the reference to dst entries that
it decided to skip.
Fixes: 0ca50d12fe46 ("sctp: fix src address selection if using secondary addresses")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/protocol.c')
| -rw-r--r-- | net/sctp/protocol.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 4345790ad326..4abf94d4cce7 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -511,8 +511,10 @@ static void sctp_v4_get_dst(struct sctp_transport *t, union sctp_addr *saddr, */ odev = __ip_dev_find(sock_net(sk), laddr->a.v4.sin_addr.s_addr, false); - if (!odev || odev->ifindex != fl4->flowi4_oif) + if (!odev || odev->ifindex != fl4->flowi4_oif) { + dst_release(&rt->dst); continue; + } dst = &rt->dst; break; |