diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-09-15 13:50:45 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-09-20 13:53:34 -0700 |
| commit | 026de64d7bc39cc77f2084c4454a562720e9c8ff (patch) | |
| tree | ed76d3655dcaca1e201dae771f1f4c55e7243388 /net/sched | |
| parent | 25becba6290bc34e369a0e1a76db9ca88bad87aa (diff) | |
| download | lwn-026de64d7bc39cc77f2084c4454a562720e9c8ff.tar.gz lwn-026de64d7bc39cc77f2084c4454a562720e9c8ff.zip | |
net/sched: taprio: add extack messages in taprio_init
Stop contributing to the proverbial user unfriendliness of tc, and tell
the user what is wrong wherever possible.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_taprio.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 2f45dfb259c9..2552f62f392d 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -1661,11 +1661,15 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt, list_add(&q->taprio_list, &taprio_list); spin_unlock(&taprio_list_lock); - if (sch->parent != TC_H_ROOT) + if (sch->parent != TC_H_ROOT) { + NL_SET_ERR_MSG_MOD(extack, "Can only be attached as root qdisc"); return -EOPNOTSUPP; + } - if (!netif_is_multiqueue(dev)) + if (!netif_is_multiqueue(dev)) { + NL_SET_ERR_MSG_MOD(extack, "Multi-queue device is required"); return -EOPNOTSUPP; + } /* pre-allocate qdisc, attachment can't fail */ q->qdiscs = kcalloc(dev->num_tx_queues, |