diff options
author | Alexei Starovoitov <ast@plumgrid.com> | 2015-08-25 20:06:32 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-08-26 11:01:44 -0700 |
commit | faa54be4c78da6aa2148c539659867afdecd3e8d (patch) | |
tree | 44eb1ad0bb5bbf322ee607666f9e50f1c82c20d5 /net/sched | |
parent | 3c645621b79828be7a46fb2694eb423b343b4bbe (diff) | |
download | lwn-faa54be4c78da6aa2148c539659867afdecd3e8d.tar.gz lwn-faa54be4c78da6aa2148c539659867afdecd3e8d.zip |
net_sched: act_bpf: remove unnecessary copy
Fix harmless typo and avoid unnecessary copy of empty 'prog' into
unused 'strcut tcf_bpf_cfg old'.
Fixes: f4eaed28c783 ("act_bpf: fix memory leaks when replacing bpf programs")
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
-rw-r--r-- | net/sched/act_bpf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c index 1b97dabc621a..458cf647e698 100644 --- a/net/sched/act_bpf.c +++ b/net/sched/act_bpf.c @@ -327,7 +327,7 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla, prog = to_bpf(act); spin_lock_bh(&prog->tcf_lock); - if (ret != ACT_P_CREATED) + if (res != ACT_P_CREATED) tcf_bpf_prog_fill_cfg(prog, &old); prog->bpf_ops = cfg.bpf_ops; |