diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2021-09-29 15:17:18 -0500 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-09-30 17:27:03 -0700 |
| commit | 129291980f4901ae68ee3ba4344bdc38cf5f800d (patch) | |
| tree | d2f1074bfe1592582b38b3757e741067eaf82b4f /net/sched/sch_netem.c | |
| parent | dd9a887b35b01d7027f974f5e7936f1410ab51ca (diff) | |
| download | lwn-129291980f4901ae68ee3ba4344bdc38cf5f800d.tar.gz lwn-129291980f4901ae68ee3ba4344bdc38cf5f800d.zip | |
net: sched: Use struct_size() helper in kvmalloc()
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows
that, in the worst scenario, could lead to heap overflows.
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210929201718.GA342296@embeddedor
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sched/sch_netem.c')
| -rw-r--r-- | net/sched/sch_netem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 0c345e43a09a..ecbb10db1111 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -785,7 +785,7 @@ static int get_dist_table(struct Qdisc *sch, struct disttable **tbl, if (!n || n > NETEM_DIST_MAX) return -EINVAL; - d = kvmalloc(sizeof(struct disttable) + n * sizeof(s16), GFP_KERNEL); + d = kvmalloc(struct_size(d, table, n), GFP_KERNEL); if (!d) return -ENOMEM; |