diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-04-01 14:39:31 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-04-03 21:37:58 -0700 |
commit | 936ee65ffc8fa35de4f20ffc867a3509568e1868 (patch) | |
tree | 0776a7877a08b298ed66e2e06f35d93d4b8e1cea /net/rxrpc/local_object.c | |
parent | 3eed52842b9fd291233c15f65fed34c5d3241183 (diff) | |
download | lwn-936ee65ffc8fa35de4f20ffc867a3509568e1868.tar.gz lwn-936ee65ffc8fa35de4f20ffc867a3509568e1868.zip |
rxrpc: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warning:
net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:
net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ret < 0) {
^
net/rxrpc/local_object.c:184:2: note: here
case AF_INET:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Currently, GCC is expecting to find the fall-through annotations
at the very bottom of the case and on its own line. That's why
I had to add the annotation, although the intentional fall-through
is already mentioned in a few lines above.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rxrpc/local_object.c')
-rw-r--r-- | net/rxrpc/local_object.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 15cf42d5b53a..9157fd00dce3 100644 --- a/net/rxrpc/local_object.c +++ b/net/rxrpc/local_object.c @@ -180,7 +180,7 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net) /* Fall through and set IPv4 options too otherwise we don't get * errors from IPv4 packets sent through the IPv6 socket. */ - + /* Fall through */ case AF_INET: /* we want to receive ICMP errors */ opt = 1; |