summaryrefslogtreecommitdiff
path: root/net/rxrpc/call_object.c
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2019-05-16 14:51:48 +0100
committerDavid Howells <dhowells@redhat.com>2019-05-16 16:25:20 +0100
commit0ab4c9594812c4bc5606daf0677ae304bf7ec8c8 (patch)
treed3041c1bb0bcb3244f9c2879d9d5cdbcc86be26f /net/rxrpc/call_object.c
parent94f699c9cdb11b8f53cb70624b69aeae16f26db2 (diff)
downloadlwn-0ab4c9594812c4bc5606daf0677ae304bf7ec8c8.tar.gz
lwn-0ab4c9594812c4bc5606daf0677ae304bf7ec8c8.zip
afs: Fix error propagation from server record check/update
afs_check/update_server_record() should be setting fc->error rather than fc->ac.error as they're called from within the cursor iteration function. afs_fs_cursor::error is where the error code of the attempt to call the operation on multiple servers is integrated and is the final result, whereas afs_addr_cursor::error is used to hold the error from individual iterations of the call loop. (Note there's also an afs_vl_cursor which also wraps afs_addr_cursor for accessing VL servers rather than file servers). Fix this by setting fc->error in the afs_check/update_server_record() so that any error incurred whilst talking to the VL server correctly propagates to the final result. This results in: kAFS: Unexpected error from FS.StoreData -512 being seen, even though the store-data op is non-interruptible. The error is actually coming from the server record update getting interrupted. Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation") Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/call_object.c')
0 files changed, 0 insertions, 0 deletions