diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2005-09-08 13:40:41 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-09-08 13:40:41 -0700 |
| commit | baed16a7ff5194487764db300c2753ac7409c4c5 (patch) | |
| tree | a6cc8276bdd41abee85df26a894980a4de5d504c /net/rose/rose_subr.c | |
| parent | 3a93481589dc80d9ff9082731f35031b0345442e (diff) | |
| download | lwn-baed16a7ff5194487764db300c2753ac7409c4c5.tar.gz lwn-baed16a7ff5194487764db300c2753ac7409c4c5.zip | |
[AX.25]: Make asc2ax() thread-proof
Asc2ax was still using a static buffer for all invocations which isn't
exactly SMP-safe. Change asc2ax to take an additional result buffer as
the argument. Change all callers to provide such a buffer.
This one only really is a fix for ROSE and as per recent discussions
there's still much more to fix in ROSE ...
Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose/rose_subr.c')
| -rw-r--r-- | net/rose/rose_subr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rose/rose_subr.c b/net/rose/rose_subr.c index 02891ce2db37..36a77944622b 100644 --- a/net/rose/rose_subr.c +++ b/net/rose/rose_subr.c @@ -337,13 +337,13 @@ static int rose_parse_ccitt(unsigned char *p, struct rose_facilities_struct *fac memcpy(&facilities->source_addr, p + 7, ROSE_ADDR_LEN); memcpy(callsign, p + 12, l - 10); callsign[l - 10] = '\0'; - facilities->source_call = *asc2ax(callsign); + asc2ax(&facilities->source_call, callsign); } if (*p == FAC_CCITT_SRC_NSAP) { memcpy(&facilities->dest_addr, p + 7, ROSE_ADDR_LEN); memcpy(callsign, p + 12, l - 10); callsign[l - 10] = '\0'; - facilities->dest_call = *asc2ax(callsign); + asc2ax(&facilities->dest_call, callsign); } p += l + 2; n += l + 2; |