diff options
| author | David S. Miller <davem@davemloft.net> | 2010-09-20 15:40:35 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-20 15:40:35 -0700 |
| commit | 9828e6e6e3f19efcb476c567b9999891d051f52f (patch) | |
| tree | c453c5981e2a9b3ea14d6c84ac73456da41c8718 /net/rose/af_rose.c | |
| parent | 3779298b81cd9a2531cec93e3beefc1acdb01382 (diff) | |
| download | lwn-9828e6e6e3f19efcb476c567b9999891d051f52f.tar.gz lwn-9828e6e6e3f19efcb476c567b9999891d051f52f.zip | |
rose: Fix signedness issues wrt. digi count.
Just use explicit casts, since we really can't change the
types of structures exported to userspace which have been
around for 15 years or so.
Reported-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose/af_rose.c')
| -rw-r--r-- | net/rose/af_rose.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index 8e45e76a95f5..d952e7eac188 100644 --- a/net/rose/af_rose.c +++ b/net/rose/af_rose.c @@ -679,7 +679,7 @@ static int rose_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) return -EINVAL; - if (addr->srose_ndigis > ROSE_MAX_DIGIS) + if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS) return -EINVAL; if ((dev = rose_dev_get(&addr->srose_addr)) == NULL) { @@ -739,7 +739,7 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_le if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) return -EINVAL; - if (addr->srose_ndigis > ROSE_MAX_DIGIS) + if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS) return -EINVAL; /* Source + Destination digis should not exceed ROSE_MAX_DIGIS */ |