diff options
| author | Zhengchao Shao <shaozhengchao@huawei.com> | 2022-07-27 17:33:12 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-29 12:09:27 +0100 |
| commit | dc633700f00f726e027846a318c5ffeb8deaaeda (patch) | |
| tree | 0f16fddf941cf27b94cc5ba489441b3beef10826 /net/packet | |
| parent | 3b1c31474cb934be352a8d75389bfe04773799c6 (diff) | |
| download | lwn-dc633700f00f726e027846a318c5ffeb8deaaeda.tar.gz lwn-dc633700f00f726e027846a318c5ffeb8deaaeda.zip | |
net/af_packet: check len when min_header_len equals to 0
User can use AF_PACKET socket to send packets with the length of 0.
When min_header_len equals to 0, packet_snd will call __dev_queue_xmit
to send packets, and sock->type can be any type.
Reported-by: syzbot+5ea725c25d06fb9114c4@syzkaller.appspotmail.com
Fixes: fd1894224407 ("bpf: Don't redirect packets with invalid pkt_len")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/packet')
| -rw-r--r-- | net/packet/af_packet.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index d08c4728523b..5cbe07116e04 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -3037,8 +3037,8 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len) if (err) goto out_free; - if (sock->type == SOCK_RAW && - !dev_validate_header(dev, skb->data, len)) { + if ((sock->type == SOCK_RAW && + !dev_validate_header(dev, skb->data, len)) || !skb->len) { err = -EINVAL; goto out_free; } |