diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-02 10:40:30 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-02-03 16:22:12 -0800 |
| commit | 7a11b1d303ee97e4880caa3efc2f5cecc28d4ba2 (patch) | |
| tree | 97dd643bb19e9f23510498531820fb575ed6cad8 /net/netlabel | |
| parent | 79b7cf60e190efa8f0689b48a45859f5c3534c76 (diff) | |
| download | lwn-7a11b1d303ee97e4880caa3efc2f5cecc28d4ba2.tar.gz lwn-7a11b1d303ee97e4880caa3efc2f5cecc28d4ba2.zip | |
netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free"
The cipso_v4_doi_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlabel')
| -rw-r--r-- | net/netlabel/netlabel_cipso_v4.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netlabel/netlabel_cipso_v4.c b/net/netlabel/netlabel_cipso_v4.c index 179625353cac..7fd1104ba900 100644 --- a/net/netlabel/netlabel_cipso_v4.c +++ b/net/netlabel/netlabel_cipso_v4.c @@ -324,8 +324,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info, return 0; add_std_failure: - if (doi_def) - cipso_v4_doi_free(doi_def); + cipso_v4_doi_free(doi_def); return ret_val; } |