diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2020-08-03 11:02:10 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2020-08-03 11:03:14 +0200 |
| commit | 5981fe5b0529ba25d95f37d7faa434183ad618c5 (patch) | |
| tree | 5bf9684c9ad7d5afc7ab1b889db81f269c35d76a /net/mac80211 | |
| parent | 3b1648f10961ce41bb709dfcadfdb9836c9a8ab8 (diff) | |
| download | lwn-5981fe5b0529ba25d95f37d7faa434183ad618c5.tar.gz lwn-5981fe5b0529ba25d95f37d7faa434183ad618c5.zip | |
mac80211: fix misplaced while instead of if
This never was intended to be a 'while' loop, it should've
just been an 'if' instead of 'while'. Fix this.
I noticed this while applying another patch from Ben that
intended to fix a busy loop at this spot.
Cc: stable@vger.kernel.org
Fixes: b16798f5b907 ("mac80211: mark station unauthorized before key removal")
Reported-by: Ben Greear <greearb@candelatech.com>
Link: https://lore.kernel.org/r/20200803110209.253009ae41ff.I3522aad099392b31d5cf2dcca34cbac7e5832dde@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211')
| -rw-r--r-- | net/mac80211/sta_info.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 1dc747de30cc..f2840d1d95cf 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -1050,7 +1050,7 @@ static void __sta_info_destroy_part2(struct sta_info *sta) might_sleep(); lockdep_assert_held(&local->sta_mtx); - while (sta->sta_state == IEEE80211_STA_AUTHORIZED) { + if (sta->sta_state == IEEE80211_STA_AUTHORIZED) { ret = sta_info_move_state(sta, IEEE80211_STA_ASSOC); WARN_ON_ONCE(ret); } |