diff options
| author | Thomas Pedersen <thomas@cozybit.com> | 2013-06-10 13:17:21 -0700 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2013-06-11 13:14:42 +0200 |
| commit | ecccd072b07e7fd09c54d0f86f9374e2645cde97 (patch) | |
| tree | 8f2bc22f2aa1cb5a96d31ec3f7d87e6400d915e2 /net/mac80211/mesh_plink.c | |
| parent | 780b40df12cf0161d8ccc5381940e04584793933 (diff) | |
| download | lwn-ecccd072b07e7fd09c54d0f86f9374e2645cde97.tar.gz lwn-ecccd072b07e7fd09c54d0f86f9374e2645cde97.zip | |
mac80211: fix mesh deadlock
The patch "cfg80211/mac80211: use cfg80211 wdev mutex in
mac80211" introduced several deadlocks by converting the
ifmsh->mtx to wdev->mtx. Solve these by:
1. drop the cancel_work_sync() in ieee80211_stop_mesh().
Instead make the mesh work conditional on whether the mesh
is running or not.
2. lock the mesh work with sdata_lock() to protect beacon
updates and prevent races with wdev->mesh_id_len or
cfg80211.
Signed-off-by: Thomas Pedersen <thomas@cozybit.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/mesh_plink.c')
| -rw-r--r-- | net/mac80211/mesh_plink.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c index 6c4da99bc4fb..09bebed99416 100644 --- a/net/mac80211/mesh_plink.c +++ b/net/mac80211/mesh_plink.c @@ -517,9 +517,7 @@ void mesh_neighbour_update(struct ieee80211_sub_if_data *sdata, ieee80211_mps_frame_release(sta, elems); out: rcu_read_unlock(); - sdata_lock(sdata); ieee80211_mbss_info_change_notify(sdata, changed); - sdata_unlock(sdata); } static void mesh_plink_timer(unsigned long data) @@ -1070,9 +1068,6 @@ void mesh_rx_plink_frame(struct ieee80211_sub_if_data *sdata, rcu_read_unlock(); - if (changed) { - sdata_lock(sdata); + if (changed) ieee80211_mbss_info_change_notify(sdata, changed); - sdata_unlock(sdata); - } } |