diff options
| author | Michal Kazior <michal.kazior@tieto.com> | 2014-09-02 14:05:10 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2014-09-03 13:40:38 +0200 |
| commit | 4549cf2b1803d29cfd019f7bfeaa784f8f9c558f (patch) | |
| tree | bf39255e299b752cea30ce8437b9a685b189e5d4 /net/mac80211/iface.c | |
| parent | d0616613d9cf17919fbd46fa0274db4b0084ad62 (diff) | |
| download | lwn-4549cf2b1803d29cfd019f7bfeaa784f8f9c558f.tar.gz lwn-4549cf2b1803d29cfd019f7bfeaa784f8f9c558f.zip | |
mac80211: fix offloaded BA session traffic after hw restart
When starting an offloaded BA session it is
unknown what starting sequence number should be
used. Using last_seq worked in most cases except
after hw restart.
When hw restart is requested last_seq is
(rightfully so) kept unmodified. This ended up
with BA sessions being restarted with an aribtrary
BA window values resulting in dropped frames until
sequence numbers caught up.
Instead of last_seq pick seqno of a first Rxed
frame of a given BA session.
This fixes stalled traffic after hw restart with
offloaded BA sessions (currently only ath10k).
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/iface.c')
| -rw-r--r-- | net/mac80211/iface.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 01eede7406a5..bb7288e3c41c 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1172,19 +1172,11 @@ static void ieee80211_iface_work(struct work_struct *work) rx_agg = (void *)&skb->cb; mutex_lock(&local->sta_mtx); sta = sta_info_get_bss(sdata, rx_agg->addr); - if (sta) { - u16 last_seq; - - last_seq = le16_to_cpu( - sta->last_seq_ctrl[rx_agg->tid]); - + if (sta) __ieee80211_start_rx_ba_session(sta, - 0, 0, - ieee80211_sn_inc(last_seq), - 1, rx_agg->tid, + 0, 0, 0, 1, rx_agg->tid, IEEE80211_MAX_AMPDU_BUF, - false); - } + false, true); mutex_unlock(&local->sta_mtx); } else if (skb->pkt_type == IEEE80211_SDATA_QUEUE_RX_AGG_STOP) { rx_agg = (void *)&skb->cb; |