diff options
| author | Thomas Pedersen <thomas@adapt-ip.com> | 2020-10-05 09:45:21 -0700 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2020-10-08 10:33:54 +0200 |
| commit | 8b783d104e7f40684333d2ec155fac39219beb2f (patch) | |
| tree | 6f93689c0dd1ef485d8d68126dabd9be0787e6be /net/mac80211/cfg.c | |
| parent | 9faebeb2d80065926dfbc09cb73b1bb7779a89cd (diff) | |
| download | lwn-8b783d104e7f40684333d2ec155fac39219beb2f.tar.gz lwn-8b783d104e7f40684333d2ec155fac39219beb2f.zip | |
mac80211: handle lack of sband->bitrates in rates
Even though a driver or mac80211 shouldn't produce a
legacy bitrate if sband->bitrates doesn't exist, don't
crash if that is the case either.
This fixes a kernel panic if station dump is run before
last_rate can be updated with a data frame when
sband->bitrates is missing (eg. in S1G bands).
Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
Link: https://lore.kernel.org/r/20201005164522.18069-1-thomas@adapt-ip.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/cfg.c')
| -rw-r--r-- | net/mac80211/cfg.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index da70f174d629..eb52aafd9381 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -709,7 +709,8 @@ void sta_set_rate_info_tx(struct sta_info *sta, u16 brate; sband = ieee80211_get_sband(sta->sdata); - if (sband) { + WARN_ON_ONCE(sband && !sband->bitrates); + if (sband && sband->bitrates) { brate = sband->bitrates[rate->idx].bitrate; rinfo->legacy = DIV_ROUND_UP(brate, 1 << shift); } |