diff options
author | Tomáš Trnka <ttrnka@mail.muni.cz> | 2016-05-20 16:41:10 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-06-07 17:21:58 -0700 |
commit | 89bd18288361ac9f737e1b805c6524fa513a50e9 (patch) | |
tree | 60c227dd182cfe1037ed90bca4d490dbb6c00b1b /net/llc | |
parent | aa77dea436de2eb3be817b96e573ca3ef856d7c3 (diff) | |
download | lwn-89bd18288361ac9f737e1b805c6524fa513a50e9.tar.gz lwn-89bd18288361ac9f737e1b805c6524fa513a50e9.zip |
sunrpc: fix stripping of padded MIC tokens
commit c0cb8bf3a8e4bd82e640862cdd8891400405cb89 upstream.
The length of the GSS MIC token need not be a multiple of four bytes.
It is then padded by XDR to a multiple of 4 B, but unwrap_integ_data()
would previously only trim mic.len + 4 B. The remaining up to three
bytes would then trigger a check in nfs4svc_decode_compoundargs(),
leading to a "garbage args" error and mount failure:
nfs4svc_decode_compoundargs: compound not properly padded!
nfsd: failed to decode arguments!
This would prevent older clients using the pre-RFC 4121 MIC format
(37-byte MIC including a 9-byte OID) from mounting exports from v3.9+
servers using krb5i.
The trimming was introduced by commit 4c190e2f913f ("sunrpc: trim off
trailing checksum before returning decrypted or integrity authenticated
buffer").
Fixes: 4c190e2f913f "unrpc: trim off trailing checksum..."
Signed-off-by: Tomáš Trnka <ttrnka@mail.muni.cz>
Acked-by: Jeff Layton <jlayton@poochiereds.net>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/llc')
0 files changed, 0 insertions, 0 deletions