diff options
| author | stephen hemminger <stephen@networkplumber.org> | 2013-02-16 07:38:15 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-02-18 12:42:47 -0500 |
| commit | 0d4bfa297c3f7efb71367449ee44f9d3fb0f5871 (patch) | |
| tree | a98de7e22a7a1397592dec4add8080b0a66e7e26 /net/ipv6/xfrm6_mode_tunnel.c | |
| parent | 2f219d5fb1184bda8398e5ab9fb2910a202e2c94 (diff) | |
| download | lwn-0d4bfa297c3f7efb71367449ee44f9d3fb0f5871.tar.gz lwn-0d4bfa297c3f7efb71367449ee44f9d3fb0f5871.zip | |
ipv6: fix warning in xfrm6_mode_tunnel_input
Should not use assignment in conditional:
warning: suggest parentheses around assignment used as truth value [-Wparentheses]
Problem introduced by:
commit 14bbd6a565e1bcdc240d44687edb93f721cfdf99
Author: Pravin B Shelar <pshelar@nicira.com>
Date: Thu Feb 14 09:44:49 2013 +0000
net: Add skb_unclone() helper function.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/xfrm6_mode_tunnel.c')
| -rw-r--r-- | net/ipv6/xfrm6_mode_tunnel.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv6/xfrm6_mode_tunnel.c b/net/ipv6/xfrm6_mode_tunnel.c index 93c41a81c4c3..9bf6a74a71d2 100644 --- a/net/ipv6/xfrm6_mode_tunnel.c +++ b/net/ipv6/xfrm6_mode_tunnel.c @@ -69,7 +69,8 @@ static int xfrm6_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb) if (!pskb_may_pull(skb, sizeof(struct ipv6hdr))) goto out; - if (err = skb_unclone(skb, GFP_ATOMIC)) + err = skb_unclone(skb, GFP_ATOMIC); + if (err) goto out; if (x->props.flags & XFRM_STATE_DECAP_DSCP) |