diff options
| author | Jarek Poplawski <jarkao2@o2.pl> | 2007-01-09 14:38:31 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-01-09 14:38:31 -0800 |
| commit | 483479ecc565b7f5845997138eddf5ecbc2684b1 (patch) | |
| tree | 0760f0ae7f2f0d4b81bc052101d150766104bd6d /net/ipv4 | |
| parent | 469de9b90f739f130ab3d483e819888e977596b8 (diff) | |
| download | lwn-483479ecc565b7f5845997138eddf5ecbc2684b1.tar.gz lwn-483479ecc565b7f5845997138eddf5ecbc2684b1.zip | |
[IPV4] devinet: inetdev_init out label moved after RCU assignment
inetdev_init out label moved after RCU assignment
(final suggestion by Herbert Xu)
Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/devinet.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 25c8a42965df..480ace9819f6 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -174,9 +174,10 @@ struct in_device *inetdev_init(struct net_device *dev) ip_mc_init_dev(in_dev); if (dev->flags & IFF_UP) ip_mc_up(in_dev); -out: + /* we can receive as soon as ip_ptr is set -- do this last */ rcu_assign_pointer(dev->ip_ptr, in_dev); +out: return in_dev; out_kfree: kfree(in_dev); |