diff options
| author | Daniel Borkmann <dborkman@redhat.com> | 2014-08-23 20:58:54 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-08-23 12:21:21 -0700 |
| commit | 8fc54f68919298ff9689d980efb495707ef43f30 (patch) | |
| tree | c8a0c89621a9e670be02764a357bb6e73ed7ab6c /net/ipv4/udp.c | |
| parent | 690e36e726d00d2528bc569809048adf61550d80 (diff) | |
| download | lwn-8fc54f68919298ff9689d980efb495707ef43f30.tar.gz lwn-8fc54f68919298ff9689d980efb495707ef43f30.zip | |
net: use reciprocal_scale() helper
Replace open codings of (((u64) <x> * <y>) >> 32) with reciprocal_scale().
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/udp.c')
| -rw-r--r-- | net/ipv4/udp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index f57c0e4c2326..32f9571e776b 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -224,7 +224,7 @@ int udp_lib_get_port(struct sock *sk, unsigned short snum, remaining = (high - low) + 1; rand = prandom_u32(); - first = (((u64)rand * remaining) >> 32) + low; + first = reciprocal_scale(rand, remaining) + low; /* * force rand to be an odd multiple of UDP_HTABLE_SIZE */ @@ -448,7 +448,7 @@ begin: } } else if (score == badness && reuseport) { matches++; - if (((u64)hash * matches) >> 32 == 0) + if (reciprocal_scale(hash, matches) == 0) result = sk; hash = next_pseudo_random32(hash); } @@ -529,7 +529,7 @@ begin: } } else if (score == badness && reuseport) { matches++; - if (((u64)hash * matches) >> 32 == 0) + if (reciprocal_scale(hash, matches) == 0) result = sk; hash = next_pseudo_random32(hash); } |