diff options
| author | Jorge Boncompte [DTI2] <jorge@dti2.net> | 2010-04-08 04:56:48 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-04-08 11:29:13 -0700 |
| commit | 1223c67c0938d2df309fde618bd82c87c8c1af04 (patch) | |
| tree | 12445eb8f4ab8acece9cd96e337ce49b29e3f31a /net/ipv4/udp.c | |
| parent | 2488f56d3699b84ee51d2940d1347345b8f9b0e1 (diff) | |
| download | lwn-1223c67c0938d2df309fde618bd82c87c8c1af04.tar.gz lwn-1223c67c0938d2df309fde618bd82c87c8c1af04.zip | |
udp: fix for unicast RX path optimization
Commits 5051ebd275de672b807c28d93002c2fb0514a3c9 and
5051ebd275de672b807c28d93002c2fb0514a3c9 ("ipv[46]: udp: optimize unicast RX
path") broke some programs.
After upgrading a L2TP server to 2.6.33 it started to fail, tunnels going up an
down, after the 10th tunnel came up. My modified rp-l2tp uses a global
unconnected socket bound to (INADDR_ANY, 1701) and one connected socket per
tunnel after parameter negotiation.
After ten sockets were open and due to mixed parameters to
udp[46]_lib_lookup2() kernel started to drop packets.
Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/udp.c')
| -rw-r--r-- | net/ipv4/udp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 7af756d0f931..24272c4cfbca 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -471,8 +471,8 @@ static struct sock *__udp4_lib_lookup(struct net *net, __be32 saddr, if (hslot->count < hslot2->count) goto begin; - result = udp4_lib_lookup2(net, INADDR_ANY, sport, - daddr, hnum, dif, + result = udp4_lib_lookup2(net, saddr, sport, + INADDR_ANY, hnum, dif, hslot2, slot2); } rcu_read_unlock(); |