diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2007-12-20 21:48:32 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 14:59:41 -0800 |
| commit | b92edbe0b8a36a833c16b0cbafb6e899b81ffc08 (patch) | |
| tree | 0d5376e9835ebfa06eb9d7f78569c1f1aeb7a301 /net/ipv4/tcp_output.c | |
| parent | 68277accb3a5f004344f4346498640601b8b7016 (diff) | |
| download | lwn-b92edbe0b8a36a833c16b0cbafb6e899b81ffc08.tar.gz lwn-b92edbe0b8a36a833c16b0cbafb6e899b81ffc08.zip | |
[TCP] Avoid two divides in tcp_output.c
Because 'free_space' variable in __tcp_select_window() is signed,
expression (free_space / 2) forces compiler to emit an integer divide.
This can be changed to a plain right shift, less expensive.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 7c50271ddc30..9a9510acb147 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -1627,7 +1627,7 @@ u32 __tcp_select_window(struct sock *sk) if (mss > full_space) mss = full_space; - if (free_space < full_space/2) { + if (free_space < (full_space >> 1)) { icsk->icsk_ack.quick = 0; if (tcp_memory_pressure) @@ -1666,7 +1666,7 @@ u32 __tcp_select_window(struct sock *sk) if (window <= free_space - mss || window > free_space) window = (free_space/mss)*mss; else if (mss == full_space && - free_space > window + full_space/2) + free_space > window + (full_space >> 1)) window = free_space; } |