diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-11-05 14:11:53 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-11-06 16:14:48 -0800 |
| commit | 288efe8606b62d0753ba6722b36ef241877251fd (patch) | |
| tree | 37cbacf02e504fafe20062ae25909a4ecfc4c807 /net/ipv4/tcp_ipv4.c | |
| parent | 7976a11b30929871a4c84c3c406d7681a3dbcc10 (diff) | |
| download | lwn-288efe8606b62d0753ba6722b36ef241877251fd.tar.gz lwn-288efe8606b62d0753ba6722b36ef241877251fd.zip | |
net: annotate lockless accesses to sk->sk_ack_backlog
sk->sk_ack_backlog can be read without any lock being held.
We need to use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing
and/or potential KCSAN warnings.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ipv4.c')
| -rw-r--r-- | net/ipv4/tcp_ipv4.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 899e100a68e6..92282f98dc82 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -2451,7 +2451,7 @@ static void get_tcp4_sock(struct sock *sk, struct seq_file *f, int i) state = inet_sk_state_load(sk); if (state == TCP_LISTEN) - rx_queue = sk->sk_ack_backlog; + rx_queue = READ_ONCE(sk->sk_ack_backlog); else /* Because we don't lock the socket, * we might find a transient negative value. |