diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2006-12-07 00:11:33 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-12-07 00:11:33 -0800 |
| commit | e16aa207ccb61c5111525c462eeeba1f3f5fd370 (patch) | |
| tree | 8a0a344fe7a3a10567075c9d63438ff6d79a1ca6 /net/ipv4/inet_timewait_sock.c | |
| parent | 26db167702756d0022f8ea5f1f30cad3018cfe31 (diff) | |
| download | lwn-e16aa207ccb61c5111525c462eeeba1f3f5fd370.tar.gz lwn-e16aa207ccb61c5111525c462eeeba1f3f5fd370.zip | |
[NET]: Memory barrier cleanups
I believe all the below memory barriers only matter on SMP so
therefore the smp_* variant of the barrier should be used.
I'm wondering if the barrier in net/ipv4/inet_timewait_sock.c should be
dropped entirely. schedule_work's implementation currently implies a
memory barrier and I think sane semantics of schedule_work() should imply
a memory barrier, as needed so the caller shouldn't have to worry.
It's not quite obvious why the barrier in net/packet/af_packet.c is
needed; maybe it should be implied through flush_dcache_page?
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/inet_timewait_sock.c')
| -rw-r--r-- | net/ipv4/inet_timewait_sock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c index 8c74f9168b7d..75373f35383f 100644 --- a/net/ipv4/inet_timewait_sock.c +++ b/net/ipv4/inet_timewait_sock.c @@ -178,7 +178,7 @@ void inet_twdr_hangman(unsigned long data) need_timer = 0; if (inet_twdr_do_twkill_work(twdr, twdr->slot)) { twdr->thread_slots |= (1 << twdr->slot); - mb(); + smp_mb(); schedule_work(&twdr->twkill_work); need_timer = 1; } else { |