diff options
| author | Jayachandran C <jchandra@digeo.com> | 2005-10-27 15:10:01 -0700 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@mandriva.com> | 2005-10-29 02:53:39 -0200 |
| commit | 9fcc2e8a752f7d3d889114221b67c459557823e9 (patch) | |
| tree | d06f567aabf247fd379a66177de5163299bc81d7 /net/ipv4/fib_frontend.c | |
| parent | 360ac8e2f1a38c3497739636c3b702352d1ad0ae (diff) | |
| download | lwn-9fcc2e8a752f7d3d889114221b67c459557823e9.tar.gz lwn-9fcc2e8a752f7d3d889114221b67c459557823e9.zip | |
[IPV4]: Fix issue reported by Coverity in ipv4/fib_frontend.c
fib_del_ifaddr() dereferences ifa->ifa_dev, so the code already assumes that
ifa->ifa_dev is non-NULL, the check is unnecessary.
Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Diffstat (limited to 'net/ipv4/fib_frontend.c')
| -rw-r--r-- | net/ipv4/fib_frontend.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index e61bc7177eb1..990633c09dfe 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -591,7 +591,7 @@ static int fib_inetaddr_event(struct notifier_block *this, unsigned long event, break; case NETDEV_DOWN: fib_del_ifaddr(ifa); - if (ifa->ifa_dev && ifa->ifa_dev->ifa_list == NULL) { + if (ifa->ifa_dev->ifa_list == NULL) { /* Last address was deleted from this interface. Disable IP. */ |