diff options
| author | Stephen Hemminger <shemminger@linux-foundation.org> | 2007-09-11 10:41:04 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-09-11 10:41:04 +0200 |
| commit | 596e41509550447b030f7b16adaeb0138ab585a8 (patch) | |
| tree | eafb66a4e5dcd5d15a8dc8187aef8d7d483b83d6 /net/ipv4/devinet.c | |
| parent | ef8aef55ce61fd0e2af798695f7386ac756ae1e7 (diff) | |
| download | lwn-596e41509550447b030f7b16adaeb0138ab585a8.tar.gz lwn-596e41509550447b030f7b16adaeb0138ab585a8.zip | |
[IPV4] devinet: show all addresses assigned to interface
Bug: http://bugzilla.kernel.org/show_bug.cgi?id=8876
Not all ips are shown by "ip addr show" command when IPs number assigned to an
interface is more than 60-80 (in fact it depends on broadcast/label etc
presence on each address).
Steps to reproduce:
It's terribly simple to reproduce:
# for i in $(seq 1 100); do ip ad add 10.0.$i.1/24 dev eth10 ; done
# ip addr show
this will _not_ show all IPs.
Looks like the problem is in netlink/ipv4 message processing.
This is fix from bug submitter, it looks correct.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/devinet.c')
| -rw-r--r-- | net/ipv4/devinet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 5b77bdaa57dd..5dbe5803b7d5 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -1193,7 +1193,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) for (ifa = in_dev->ifa_list, ip_idx = 0; ifa; ifa = ifa->ifa_next, ip_idx++) { if (ip_idx < s_ip_idx) - goto cont; + continue; if (inet_fill_ifaddr(skb, ifa, NETLINK_CB(cb->skb).pid, cb->nlh->nlmsg_seq, RTM_NEWADDR, NLM_F_MULTI) <= 0) |