diff options
| author | Alexander Aring <aring@mojatatu.com> | 2018-04-20 15:15:05 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-04-22 21:12:00 -0400 |
| commit | d57493d6d1be26c8ac8516a4463bfe24956978eb (patch) | |
| tree | 5386270f315c29fb679d6247f53eae936656fbd4 /net/ife | |
| parent | cc74eddd0ff325d57373cea99f642b787d7f76f5 (diff) | |
| download | lwn-d57493d6d1be26c8ac8516a4463bfe24956978eb.tar.gz lwn-d57493d6d1be26c8ac8516a4463bfe24956978eb.zip | |
net: sched: ife: check on metadata length
This patch checks if sk buffer is available to dererence ife header. If
not then NULL will returned to signal an malformed ife packet. This
avoids to crashing the kernel from outside.
Signed-off-by: Alexander Aring <aring@mojatatu.com>
Reviewed-by: Yotam Gigi <yotam.gi@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ife')
| -rw-r--r-- | net/ife/ife.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ife/ife.c b/net/ife/ife.c index 7fbe70a0af4b..13bbf8cb6a39 100644 --- a/net/ife/ife.c +++ b/net/ife/ife.c @@ -69,6 +69,9 @@ void *ife_decode(struct sk_buff *skb, u16 *metalen) int total_pull; u16 ifehdrln; + if (!pskb_may_pull(skb, skb->dev->hard_header_len + IFE_METAHDRLEN)) + return NULL; + ifehdr = (struct ifeheadr *) (skb->data + skb->dev->hard_header_len); ifehdrln = ntohs(ifehdr->metalen); total_pull = skb->dev->hard_header_len + ifehdrln; |