diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-11-28 12:03:30 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-11-29 20:16:46 -0800 |
| commit | 72a2ff567fc38a3648507c5386a383007400bb3a (patch) | |
| tree | c2b390cca7821520d5791b2a90a807af6310475d /net/ethtool | |
| parent | a21ee5b2fcb8d6d3973446c5039e966c4cfe40d1 (diff) | |
| download | lwn-72a2ff567fc38a3648507c5386a383007400bb3a.tar.gz lwn-72a2ff567fc38a3648507c5386a383007400bb3a.zip | |
ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'
The 'dest' bitmap is fully initialized by the 'for' loop, so there is no
need to explicitly reset it.
This also makes this function in line with 'ethnl_features_to_bitmap32()'
which does not clear the destination before writing it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/17fca158231c6f03689bd891254f0dd1f4e84cb8.1638091829.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ethtool')
| -rw-r--r-- | net/ethtool/features.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ethtool/features.c b/net/ethtool/features.c index 1c9f4df273bd..2e7331b23996 100644 --- a/net/ethtool/features.c +++ b/net/ethtool/features.c @@ -136,7 +136,6 @@ static void ethnl_features_to_bitmap(unsigned long *dest, netdev_features_t val) const unsigned int words = BITS_TO_LONGS(NETDEV_FEATURE_COUNT); unsigned int i; - bitmap_zero(dest, NETDEV_FEATURE_COUNT); for (i = 0; i < words; i++) dest[i] = (unsigned long)(val >> (i * BITS_PER_LONG)); } |