diff options
author | Phil Blundell <philb@gnu.org> | 2010-11-24 11:49:53 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-11-24 11:49:53 -0800 |
commit | 16c41745c7b92a243d0874f534c1655196c64b74 (patch) | |
tree | f30468ec3c9beb4d375ca1b0350c934e07d3b54f /net/econet/af_econet.c | |
parent | fa0e846494792e722d817b9d3d625a4ef4896c96 (diff) | |
download | lwn-16c41745c7b92a243d0874f534c1655196c64b74.tar.gz lwn-16c41745c7b92a243d0874f534c1655196c64b74.zip |
econet: fix CVE-2010-3850
Add missing check for capable(CAP_NET_ADMIN) in SIOCSIFADDR operation.
Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/econet/af_econet.c')
-rw-r--r-- | net/econet/af_econet.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index e366f1bef91f..d41ba8e56c10 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -661,6 +661,9 @@ static int ec_dev_ioctl(struct socket *sock, unsigned int cmd, void __user *arg) err = 0; switch (cmd) { case SIOCSIFADDR: + if (!capable(CAP_NET_ADMIN)) + return -EPERM; + edev = dev->ec_ptr; if (edev == NULL) { /* Magic up a new one. */ |