summaryrefslogtreecommitdiff
path: root/net/dccp
diff options
context:
space:
mode:
authorChris Wright <chrisw@sous-sol.org>2008-05-05 13:50:24 -0700
committerDavid S. Miller <davem@davemloft.net>2008-05-05 13:50:24 -0700
commit19443178fbfbf40db15c86012fc37df1a44ab857 (patch)
treee41cd59c5e6aba6f5ca932c9131f73e563b02bf8 /net/dccp
parent7a1aa309f21ea2f6c31f364341e4027ecf4e79bc (diff)
downloadlwn-19443178fbfbf40db15c86012fc37df1a44ab857.tar.gz
lwn-19443178fbfbf40db15c86012fc37df1a44ab857.zip
dccp: return -EINVAL on invalid feature length
dccp_feat_change() validates length and on error is returning 1. This happens to work since call chain is checking for 0 == success, but this is returned to userspace, so make it a real error value. Signed-off-by: Chris Wright <chrisw@sous-sol.org> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp')
-rw-r--r--net/dccp/feat.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index 4a4f6ce4498d..933a0ecf8d46 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -32,7 +32,7 @@ int dccp_feat_change(struct dccp_minisock *dmsk, u8 type, u8 feature,
if (len > 3) {
DCCP_WARN("invalid length %d\n", len);
- return 1;
+ return -EINVAL;
}
/* XXX add further sanity checks */