diff options
| author | Vlad Yasevich <vyasevich@gmail.com> | 2015-12-14 17:44:10 -0500 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-01-05 18:18:01 +0100 |
| commit | 15c057e4548f1c655d21eb22fc52f7d62dff5c9f (patch) | |
| tree | f401650b0e7aaa5f5bcdc9a7a47d826b38df8815 /net/core | |
| parent | d28675612dc30d4011b818c1a079bc706097bf9e (diff) | |
| download | lwn-15c057e4548f1c655d21eb22fc52f7d62dff5c9f.tar.gz lwn-15c057e4548f1c655d21eb22fc52f7d62dff5c9f.zip | |
skbuff: Fix offset error in skb_reorder_vlan_header
[ Upstream commit f654861569872d10dcb79d9d7ca219b316f94ff0 ]
skb_reorder_vlan_header is called after the vlan header has
been pulled. As a result the offset of the begining of
the mac header has been incrased by 4 bytes (VLAN_HLEN).
When moving the mac addresses, include this incrase in
the offset calcualation so that the mac addresses are
copied correctly.
Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off)
CC: Nicolas Dichtel <nicolas.dichtel@6wind.com>
CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: Vladislav Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/skbuff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index be70fe425542..56cdf3bb1e7f 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3583,7 +3583,7 @@ static struct sk_buff *skb_reorder_vlan_header(struct sk_buff *skb) return NULL; } - memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len, + memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len - VLAN_HLEN, 2 * ETH_ALEN); skb->mac_header += VLAN_HLEN; return skb; |