diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2020-10-05 17:48:38 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-10-06 06:14:02 -0700 |
| commit | 302af7c6049dc2cbd1e07358c1912f7cce98db36 (patch) | |
| tree | 34bd6553f0fb82acce9da0b40bd82752c648becb /net/core/skbuff.c | |
| parent | 717f20341686245fdde9000ee09fdab5dc722477 (diff) | |
| download | lwn-302af7c6049dc2cbd1e07358c1912f7cce98db36.tar.gz lwn-302af7c6049dc2cbd1e07358c1912f7cce98db36.zip | |
net: always dump full packets with skb_dump
Currently skb_dump has a restriction to only dump full packet for the
first 5 socket buffers, then only headers will be printed. Remove this
arbitrary and confusing restriction, which is only documented vaguely
("up to") in the comments above the prototype.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/skbuff.c')
| -rw-r--r-- | net/core/skbuff.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index c8afa2c42c1a..7cba279e7138 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -712,11 +712,10 @@ EXPORT_SYMBOL(kfree_skb_list); * * Must only be called from net_ratelimit()-ed paths. * - * Dumps up to can_dump_full whole packets if full_pkt, headers otherwise. + * Dumps whole packets if full_pkt, only headers otherwise. */ void skb_dump(const char *level, const struct sk_buff *skb, bool full_pkt) { - static atomic_t can_dump_full = ATOMIC_INIT(5); struct skb_shared_info *sh = skb_shinfo(skb); struct net_device *dev = skb->dev; struct sock *sk = skb->sk; @@ -726,9 +725,6 @@ void skb_dump(const char *level, const struct sk_buff *skb, bool full_pkt) int i, len, seg_len; if (full_pkt) - full_pkt = atomic_dec_if_positive(&can_dump_full) >= 0; - - if (full_pkt) len = skb->len; else len = min_t(int, skb->len, MAX_HEADER + 128); |