diff options
| author | Eric Dumazet <edumazet@google.com> | 2020-06-17 09:40:51 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-06-18 20:29:56 -0700 |
| commit | 427d5838e99632e9218eae752009c873cade89ac (patch) | |
| tree | 81648eea57dce39fe1d8b71f275604ac6f81ff84 /net/core/dev.c | |
| parent | 4e638025f25652b052ec54cf75e4cfe4f4663ce7 (diff) | |
| download | lwn-427d5838e99632e9218eae752009c873cade89ac.tar.gz lwn-427d5838e99632e9218eae752009c873cade89ac.zip | |
net: napi: remove useless stack trace
Whenever a buggy NAPI driver returns more than its budget,
we emit a stack trace that is of no use, since it does not
tell which driver is buggy.
Instead, emit a message giving the function name, and a
descriptive message.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 6bc2388141f6..cea7fc1716ca 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6683,7 +6683,9 @@ static int napi_poll(struct napi_struct *n, struct list_head *repoll) trace_napi_poll(n, work, weight); } - WARN_ON_ONCE(work > weight); + if (unlikely(work > weight)) + pr_err_once("NAPI poll function %pS returned %d, exceeding its budget of %d.\n", + n->poll, work, weight); if (likely(work < weight)) goto out_unlock; |