diff options
author | Marc Kleine-Budde <mkl@pengutronix.de> | 2023-10-04 11:46:27 +0200 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2023-10-04 11:53:26 +0200 |
commit | 2806d74deb42f7a253a40d032153c628f37c19ce (patch) | |
tree | d4abd9f3483c516a35c1e5d359ed49569cd7eac7 /net/can | |
parent | e36c56bf77d53f649de7d6bfc6d87539ea4b7549 (diff) | |
parent | 4f8005092cafc194ba6a8e5f39626ba0b9f08271 (diff) | |
download | lwn-2806d74deb42f7a253a40d032153c628f37c19ce.tar.gz lwn-2806d74deb42f7a253a40d032153c628f37c19ce.zip |
Merge patch series "can: etas_es58x: clean-up of new GCC W=1 and old checkpatch warnings"
Vincent Mailhol <mailhol.vincent@wanadoo.fr> says:
The kernel recently added new warnings, one of which triggers a known
false positive on the etas_es58x module. In an effort to keep
es58x_etas free of any W=12 (excluding those produced by foreign
headers), add a workaround to silence it.
While at it, this series also fix a checkpatch warning which I knew
existed for a long time but was too lazy to tackle.
v2 -> v3:
* if the parsing of one of the version/revision numbers fail,
es58x_parse_product_info() immediately returns. If this occurs early,
the other version/revision numbers would still be set to zero (which
is now considered a valid version number). Set the version and
revision to an invalid number before starting the parsing so that
everything is set even if an early return occurs.
v1 -> v2:
* v1 had two different check logics for the version numbers:
- check that none of the sub-version number are zero to make sure
the parsing succeeded
- check that all of the sub-version number fit the expected digit
range to please GCC.
v2 simplifies things by merging those two logics together.
Link: https://lore.kernel.org/all/20230924110914.183898-1-mailhol.vincent@wanadoo.fr
[mkl: fixed typos]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'net/can')
0 files changed, 0 insertions, 0 deletions