diff options
| author | Ignat Korchagin <ignat@cloudflare.com> | 2024-10-14 16:38:03 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-10-15 18:43:08 -0700 |
| commit | 811a7ca7320c062e15d0f5b171fe6ad8592d1434 (patch) | |
| tree | e2828100b98f78a8bd1b1f2e71278573c96a0d8e /net/can | |
| parent | 3945c799f12b8d1f49a3b48369ca494d981ac465 (diff) | |
| download | lwn-811a7ca7320c062e15d0f5b171fe6ad8592d1434.tar.gz lwn-811a7ca7320c062e15d0f5b171fe6ad8592d1434.zip | |
net: af_can: do not leave a dangling sk pointer in can_create()
On error can_create() frees the allocated sk object, but sock_init_data()
has already attached it to the provided sock object. This will leave a
dangling sk pointer in the sock object and may cause use-after-free later.
Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20241014153808.51894-5-ignat@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/can')
| -rw-r--r-- | net/can/af_can.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/can/af_can.c b/net/can/af_can.c index 707576eeeb58..01f3fbb3b67d 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -171,6 +171,7 @@ static int can_create(struct net *net, struct socket *sock, int protocol, /* release sk on errors */ sock_orphan(sk); sock_put(sk); + sock->sk = NULL; } errout: |