diff options
| author | Eric Dumazet <edumazet@google.com> | 2015-05-28 04:42:54 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-05-30 23:31:28 -0700 |
| commit | 71d9f6149cac8fc6646adfb2a6f3b0de6ddd23f6 (patch) | |
| tree | b2cb34293f904f1346b38770ab223195d466ea2c /net/bridge | |
| parent | 5aab0e8a45e2c15930af9aea7f461bf57ad8efe3 (diff) | |
| download | lwn-71d9f6149cac8fc6646adfb2a6f3b0de6ddd23f6.tar.gz lwn-71d9f6149cac8fc6646adfb2a6f3b0de6ddd23f6.zip | |
bridge: fix br_multicast_query_expired() bug
br_multicast_query_expired() querier argument is a pointer to
a struct bridge_mcast_querier :
struct bridge_mcast_querier {
struct br_ip addr;
struct net_bridge_port __rcu *port;
};
Intent of the code was to clear port field, not the pointer to querier.
Fixes: 2cd4143192e8 ("bridge: memorize and export selected IGMP/MLD querier port")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
Cc: Linus Lüssing <linus.luessing@web.de>
Cc: Steinar H. Gunderson <sesse@samfundet.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
| -rw-r--r-- | net/bridge/br_multicast.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index a3abe6ed111e..22fd0419b314 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br, if (query->startup_sent < br->multicast_startup_query_count) query->startup_sent++; - RCU_INIT_POINTER(querier, NULL); + RCU_INIT_POINTER(querier->port, NULL); br_multicast_send_query(br, NULL, query); spin_unlock(&br->multicast_lock); } |